From b8672a44d004cdcd423fc20302a8908be5be7d82 Mon Sep 17 00:00:00 2001
From: xCyanGrizzly <sam.agsteribbe@hotmail.com>
Date: Thu, 13 Aug 2026 18:52:34 +0200
Subject: [PATCH] feat(worker): forward on allowsForwarding channels regardless
 of file type or listing success
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

tryForwardArchiveSet only attempted the no-download forward path for
ZIP/RAR/7z archives, and bailed to download+reupload whenever the
ranged listing failed — even though the channel already grants
forwarding permission and forwarding a message costs nothing
regardless of what's inside it. Standalone DOCUMENT/STL/3MF
attachments never got a chance at the forward path at all.

Now any file on a forwarding-enabled channel is forwarded directly;
when there's no listing to derive a content hash from (non-archive
types, or ranged-listing failures), dedup falls back to
remote.unique_id identity — deriveForwardContentHash, crcFingerprint,
and compareFingerprints already degrade to this safely for
empty/incomplete entries, so there's no risk of unrelated files
colliding as false duplicates. Inner-file indexing is simply skipped
for these cases, matching the existing accepted limitation for
RAR/7z rebuild placeholders.
---
 worker/src/worker.ts | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/worker/src/worker.ts b/worker/src/worker.ts
index ca132c8..7e1a00e 100644
--- a/worker/src/worker.ts
+++ b/worker/src/worker.ts
@@ -2388,12 +2388,6 @@ async function tryForwardArchiveSet(
 
   const archiveName = archiveSet.parts[0].fileName;
   const archType = archiveSet.type === "7Z" ? ("SEVEN_Z" as const) : archiveSet.type;
-  if (archType !== "ZIP" && archType !== "RAR" && archType !== "SEVEN_Z") {
-    // The ranged listing readers only cover archive formats. Standalone
-    // DOCUMENT attachments always go through the existing download path,
-    // which for DOCUMENT is already cheap (no extraction, single entry).
-    return undefined;
-  }
 
   const scannedParts = archiveSet.parts.map((p) => ({
     fileId: p.fileId,
@@ -2401,8 +2395,19 @@ async function tryForwardArchiveSet(
     fileName: p.fileName,
   }));
 
-  const entries = await readScannedListingRanged(archType, client, scannedParts);
-  if (!entries) return undefined;
+  // Only ZIP/RAR/7z have a ranged-listing reader. For anything else (a
+  // standalone DOCUMENT/STL/3MF attachment), or when the ranged listing
+  // fails for a type that does have one, forward anyway with an empty
+  // entries list instead of falling back to download+reupload —
+  // deriveForwardContentHash and the repost/dedup checks all degrade
+  // gracefully to remote.unique_id-based identity when entries are
+  // empty/incomplete (see forward-identity.ts), and the entire point of a
+  // forwarding-enabled channel is to avoid the download+reupload cost
+  // regardless of whether inner contents can be indexed.
+  const entries =
+    archType === "ZIP" || archType === "RAR" || archType === "SEVEN_Z"
+      ? (await readScannedListingRanged(archType, client, scannedParts)) ?? []
+      : [];
 
   const totalArchiveSize = archiveSet.parts.reduce((sum, p) => sum + p.fileSize, 0n);
   const firstRemoteUniqueId = archiveSet.parts[0].remoteUniqueId ?? null;