mirror of
https://github.com/xCyanGrizzly/DragonsStash.git
synced 2026-06-13 04:31:16 +00:00
The old verifyMessageExists returned a bare boolean. Any error other
than HTTP 404 was treated as "exists" — meaning a TDLib connection
problem or transient TG hiccup at recovery time caused the worker to
declare "all destination messages verified" when it had actually
verified nothing.
Replaced with a discriminated VerifyResult:
- exists — message present and is a document, keep Package
- deleted — TG confirms it's gone (404 / MESSAGE_ID_INVALID /
"Message not found"), reset Package for re-upload
- wrong-content — message exists but isn't messageDocument, reset
- unknown — TDLib threw a non-404 error; do NOT reset, retry
next startup
Recovery summary now reports all four counts and switches to a
non-success message when unknownCount > 0, so a degraded TDLib run
doesn't hide behind a green log line.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
224 lines
7.0 KiB
TypeScript
224 lines
7.0 KiB
TypeScript
import { childLogger } from "./util/logger.js";
|
|
import { createTdlibClient, closeTdlibClient } from "./tdlib/client.js";
|
|
import { withFloodWait } from "./util/retry.js";
|
|
import {
|
|
getActiveAccounts,
|
|
getPackagesWithDestMessage,
|
|
resetPackageDestination,
|
|
getGlobalDestinationChannel,
|
|
} from "./db/queries.js";
|
|
import type { Client } from "tdl";
|
|
|
|
const log = childLogger("recovery");
|
|
|
|
/**
|
|
* Verify that destination messages still exist in Telegram for all
|
|
* packages that claim to be uploaded. If a message is missing (deleted
|
|
* or never actually committed), reset the package so the next ingestion
|
|
* run will re-download and re-upload it.
|
|
*
|
|
* This handles the case where the worker crashed mid-upload: TDLib may
|
|
* have returned a temporary message ID that was stored as destMessageId
|
|
* but the upload never completed server-side, or the message was later
|
|
* deleted from the destination channel.
|
|
*
|
|
* Called once on worker startup, before the scheduler begins.
|
|
*/
|
|
export async function recoverIncompleteUploads(): Promise<void> {
|
|
const packages = await getPackagesWithDestMessage();
|
|
if (packages.length === 0) {
|
|
log.debug("No packages with destination messages to verify");
|
|
return;
|
|
}
|
|
|
|
// We need a TDLib client to verify messages. Use the first active account.
|
|
const accounts = await getActiveAccounts();
|
|
if (accounts.length === 0) {
|
|
log.info("No active accounts available for upload verification, skipping recovery");
|
|
return;
|
|
}
|
|
|
|
const destChannel = await getGlobalDestinationChannel();
|
|
if (!destChannel) {
|
|
log.info("No destination channel configured, skipping recovery");
|
|
return;
|
|
}
|
|
|
|
// Group packages by destChannelId for efficient verification
|
|
const byChannel = new Map<string, typeof packages>();
|
|
for (const pkg of packages) {
|
|
const channelId = pkg.destChannelId!;
|
|
if (!byChannel.has(channelId)) {
|
|
byChannel.set(channelId, []);
|
|
}
|
|
byChannel.get(channelId)!.push(pkg);
|
|
}
|
|
|
|
log.info(
|
|
{ totalPackages: packages.length, channels: byChannel.size },
|
|
"Verifying destination messages exist in Telegram"
|
|
);
|
|
|
|
const account = accounts[0];
|
|
let client: Client | undefined;
|
|
|
|
try {
|
|
({ client } = await createTdlibClient({ id: account.id, phone: account.phone }));
|
|
|
|
// Load the chat list so TDLib can resolve chat IDs
|
|
try {
|
|
await client.invoke({
|
|
_: "getChats",
|
|
chat_list: { _: "chatListMain" },
|
|
limit: 1000,
|
|
});
|
|
} catch {
|
|
// May already be loaded
|
|
}
|
|
|
|
let resetCount = 0;
|
|
let verifiedCount = 0;
|
|
let unknownCount = 0;
|
|
let wrongContentCount = 0;
|
|
|
|
for (const [, channelPackages] of byChannel) {
|
|
for (const pkg of channelPackages) {
|
|
const result = await verifyMessageExists(
|
|
client,
|
|
destChannel.telegramId,
|
|
pkg.destMessageId!
|
|
);
|
|
|
|
if (result.state === "exists") {
|
|
verifiedCount++;
|
|
} else if (result.state === "deleted") {
|
|
log.warn(
|
|
{
|
|
packageId: pkg.id,
|
|
fileName: pkg.fileName,
|
|
destMessageId: Number(pkg.destMessageId),
|
|
},
|
|
"Destination message missing in Telegram, resetting package for re-upload"
|
|
);
|
|
await resetPackageDestination(pkg.id);
|
|
resetCount++;
|
|
} else if (result.state === "wrong-content") {
|
|
// The message exists but isn't a document anymore (got cleared /
|
|
// replaced). Treat as missing so we re-upload.
|
|
log.warn(
|
|
{
|
|
packageId: pkg.id,
|
|
fileName: pkg.fileName,
|
|
destMessageId: Number(pkg.destMessageId),
|
|
contentType: result.contentType,
|
|
},
|
|
"Destination message is not a document, resetting package for re-upload"
|
|
);
|
|
await resetPackageDestination(pkg.id);
|
|
wrongContentCount++;
|
|
} else {
|
|
// Unknown — TDLib couldn't tell us. Don't reset, but DO count this
|
|
// so the summary line shows recovery wasn't 100% successful.
|
|
unknownCount++;
|
|
log.warn(
|
|
{
|
|
packageId: pkg.id,
|
|
fileName: pkg.fileName,
|
|
destMessageId: Number(pkg.destMessageId),
|
|
reason: result.reason.slice(0, 200),
|
|
},
|
|
"Could not verify destination message — will retry on next startup"
|
|
);
|
|
}
|
|
}
|
|
}
|
|
|
|
log.info(
|
|
{
|
|
verifiedCount,
|
|
resetCount,
|
|
wrongContentCount,
|
|
unknownCount,
|
|
totalChecked: packages.length,
|
|
},
|
|
unknownCount === 0
|
|
? "Upload recovery complete"
|
|
: "Upload recovery complete — some packages could not be verified, will retry next startup"
|
|
);
|
|
} catch (err) {
|
|
log.error({ err }, "Upload recovery failed (non-fatal, will retry next startup)");
|
|
} finally {
|
|
if (client) {
|
|
await closeTdlibClient(client);
|
|
}
|
|
}
|
|
}
|
|
|
|
type VerifyResult =
|
|
| { state: "exists" }
|
|
| { state: "deleted" }
|
|
| { state: "wrong-content"; contentType: string }
|
|
| { state: "unknown"; reason: string };
|
|
|
|
/**
|
|
* Check whether a message exists in a Telegram chat and is the document we
|
|
* uploaded. Returns a discriminated result instead of a bare boolean so the
|
|
* caller can distinguish "definitely gone" (reset) from "couldn't reach TG"
|
|
* (leave alone, try again next startup).
|
|
*
|
|
* Previous version conflated all non-404 errors with "exists", which masked
|
|
* recovery completely when TDLib had a degraded connection — the worker
|
|
* would log "all destination messages verified" even though it had answered
|
|
* questions it couldn't actually answer.
|
|
*/
|
|
async function verifyMessageExists(
|
|
client: Client,
|
|
chatTelegramId: bigint,
|
|
messageId: bigint
|
|
): Promise<VerifyResult> {
|
|
try {
|
|
const result = await withFloodWait(
|
|
() =>
|
|
client.invoke({
|
|
_: "getMessage",
|
|
chat_id: Number(chatTelegramId),
|
|
message_id: Number(messageId),
|
|
}),
|
|
"getMessage:verify"
|
|
);
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
const msg = result as any;
|
|
if (!msg || !msg.content) {
|
|
return { state: "deleted" };
|
|
}
|
|
|
|
if (msg.content._ !== "messageDocument") {
|
|
return { state: "wrong-content", contentType: String(msg.content._) };
|
|
}
|
|
|
|
return { state: "exists" };
|
|
} catch (err) {
|
|
const errMessage = err instanceof Error ? err.message : String(err);
|
|
const code = (err as { code?: number })?.code;
|
|
|
|
// Hard "the message is definitely gone" signals from TDLib:
|
|
// - HTTP 404
|
|
// - "Message not found" / "MESSAGE_ID_INVALID" error strings
|
|
const lower = errMessage.toLowerCase();
|
|
if (
|
|
code === 404 ||
|
|
lower.includes("message not found") ||
|
|
lower.includes("message_id_invalid") ||
|
|
lower.includes("messageidinvalid") ||
|
|
lower.includes("not found")
|
|
) {
|
|
return { state: "deleted" };
|
|
}
|
|
|
|
// Everything else (network, connection, TDLib internal) is genuinely
|
|
// unknown — do NOT claim "verified".
|
|
return { state: "unknown", reason: errMessage };
|
|
}
|
|
}
|